fix(workspace): re-apply #89182 back-button handler simplification#89675
Conversation
…cation PR Expensify#87283 (Submit workspace onboarding) was merged with a stale conflict resolution that brought back the pre-Expensify#89182 multi-line onBackButtonPress handler, effectively reverting the fix for Expensify#88970 ("Back button leads to Inbox tab from workspace overview page"). Re-apply the one-liner so a backTo route is always passed to Navigation.goBack().
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
On it 🫡 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-05-06.at.08.39.03.moviOS: mWeb SafariScreen.Recording.2026-05-06.at.08.46.26.movMacOS: Chrome / SafariScreen.Recording.2026-05-06.at.08.45.44.mov |
|
Verify it's fixed: Screen.Recording.2026-05-06.at.08.39.03.mov |
|
🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.3.67-11 🚀
Bundle Size Analysis (Sentry): |
|
After reviewing the changes in this PR, no help site updates are required. The PR simplifies the back-button navigation handler on the workspace overview page ( |
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.3.67-13 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.3.68-0 🚀
Bundle Size Analysis (Sentry): |
|
This PR simplifies the back-button navigation logic in No help site documentation changes are required. |
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.3.68-3 🚀
|
Explanation of Change
Always pass an explicit
backToroute toNavigation.goBackfrom the workspace overview page header insrc/pages/workspace/WorkspaceInitialPage.tsx.Fixed Issues
$ #89674
PROPOSAL:
Tests
Offline tests
Unnecessary
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-05-06.at.02.29.15.mov
iOS: mWeb Safari
Screen.Recording.2026-05-06.at.02.31.40.mov
MacOS: Chrome / Safari
Screen.Recording.2026-05-06.at.02.21.20.mov